Skip to content

Fix flakey time-senstive group filter specs

Eric Eastwood requested to merge fix-flakey-groups-filter-list-specs into master

What does this MR do?

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6150

Fix flakey time-senstive group filter specs

Found while working on https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6051, failing test: https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/74649298

Are there points in the code the reviewer needs to double check?

These tests passed previously because the filtered group search is debounced by 0.5s. The test cleared the input, entered group1, cleared the input, entered nothing, and the all of groups are still listed because of the 0.5s debounce hasn't triggered and the test passes before anything is actually filtered.

Even if we assert that the list is filtered before clearing the input, the test still fails because the nature of the fill_in 'filter', with: "" method is that "if you're setting the value to "", no keys are ever actually sent, hence no [input] event" and we never filter back to everything in the list.

So the solution is two-fold, add in the assertions that the list is actually filtered after each step. Then use a method that fills the input with proper events fired.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Rémy Coutable

Merge request reports