Improve empty project overview (!16617) · Merge requests · GitLab.org / GitLab FOSS

George Tsiolis requested to merge gtsiolis/gitlab-foss:feat/add-section-headers-to-project-repo-buttons into master Jan 22, 2018

What does this MR do?

Adds section headers to project repo buttons. (See image D, E)
Adds primary button to content to add file when the repository is empty. (See image F)
Changes project removal primary button from project overview to secondary button. There was a primary button for project removal on the bottom right corner visible on empty repo project overview which has been changed to secondary button after the addition of the New file primary button. (See image G)
Updated headings for better alignment and to avoid inserting more CSS (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16617#note_55630753) (See image J)
Add primary button for readme only user preference. (See image H)

Are there points in the code the reviewer needs to double check?

Maybe write a test for the new button New file.

Why was this MR needed?

Let's start with !16394 (merged) which adds section headers to plus button dropdown next to file path breadcrumb (See #41128 (moved)). Since we decided to merge !16394 (merged), we need to add some section headers to project repo buttons. Project dropdown currently includes New issue and New merge request which is also present to the global dropdown so it is safe to include these button group as is with the label This project. However, this mixed New file, New branch and New tag button group may be confusing for the user since the aforementioned MR separates these options.

To remove further confusion, I would suggest to add two button groups (as @dimitrieh said here) but also move the New file option within the empty project block (See image F).

/cc @jramsay @sarrahvesselov @annabeldunstone