Skip to content

Change Page::Main::Entry to only visit an entrypoint and introduce Page::Main::Login to handle actual log-in

Rémy Coutable requested to merge rc/gitlab-qa-89 into master

What does this MR do?

Attempt to handle the case where the custom homepage is external to the GitLab instance. See gitlab-qa#89 (closed).

  1. Change Page::Main::Entry to only visit an entrypoint and introduce Page::Main::Login to handle actual log-in
  2. Escape the password for Git calls (the staging password had characters that needed to be escaped!)
  3. Pass ARGV to #launch! otherwise we only retrieve the first arg in #launch (the recent introduction of Bootable#launch! broke things)!

What are the relevant issue numbers?

Solves gitlab-qa#89 (closed).

Edited by Rémy Coutable

Merge request reports