Loading
Fix ordering of commits in the network graph.
What does this MR do?
-
We upgraded
ruggedto 0.25.1.1 in !10286 (merged) for %9.1 -
Prior to this upgrade, the default sort order for commits returned by
Gitlab::Git::Repository#find_commitswasRugged::SORT_DATE, which the graph relied on. -
While upgrading
rugged, the MR also changed this default toRugged::SORT_NONE, which broke commit ordering in the graph. -
This MR adds an option to
Gitlab::Git::Repository#find_commitsto sort by date, and changes the graph builderNetwork::Graphso it explictly requests the:datesort order
What are the relevant issue numbers?
Closes #30973 (closed)
Tasks
- Investigation
- Implementation
- Tests
- Added
- Add more tests for
Network::Graph - Compare results of this fix v/s 9.0 and confirm that there are no changes
- Add more tests for
- Passing
- Added
- Meta
- CHANGELOG entry created
-
API support added - Branch has no merge conflicts with
master - Squashed related commits together
-
Added screenshots - Check for clean merge with EE
-
Documentation added/updated
- Review
- Reviewer
- Maintainer
- Wait for merge