Skip to content
Snippets Groups Projects

Fix the MR widget that merged any MR when choosing the option "Merge when pipeline succeeds" from the dropdown

Merged Jose Ivan Vargas requested to merge mr-widget-bug-fix into master
All threads resolved!

What does this MR do?

Fixes the dropdown option Merge when Pipeline succeeds merging the MR immediately

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

closes #29568 (closed)

cc @stanhu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jose Ivan Vargas resolved all discussions

    resolved all discussions

  • added 1 commit

    • da62f567 - Added tests and fixed a typo

    Compare with previous version

  • added 1 commit

    • da62f567 - Added tests and fixed a typo

    Compare with previous version

  • Don't forget to add a CHANGELOG entry!

  • Sorry, just added it :thumbsup:

  • added 1 commit

    Compare with previous version

  • Stan Hu enabled an automatic merge when the pipeline for 4a49b376 succeeds

    enabled an automatic merge when the pipeline for 4a49b376 succeeds

  • assigned to @stanhu

  • Jose Ivan Vargas marked the task Changelog entry added, if necessary as completed

    marked the task Changelog entry added, if necessary as completed

  • Jose Ivan Vargas marked the task Added for this feature/bug as completed

    marked the task Added for this feature/bug as completed

  • Stan Hu added 19 commits

    added 19 commits

    Compare with previous version

  • Stan Hu enabled an automatic merge when the pipeline for 35acd1e9 succeeds

    enabled an automatic merge when the pipeline for 35acd1e9 succeeds

  • @jameslopez @twk3 @godfat This will need to be picked into 9-0-stable as well.

    @felipe_artur @godfat @selfup @timothyandrew Please set the milestone to %9.0 once picked into 9-1-stable.

  • Rémy Coutable changed milestone to %9.1

    changed milestone to %9.1

  • merged

  • Stan Hu mentioned in commit 862b74bc

    mentioned in commit 862b74bc

  • Picked into 9-1-stable, will go into 9.1-RC1

  • Felipe Cardozo removed ~149423 label

    removed ~149423 label

  • Felipe Cardozo changed milestone to %9.0

    changed milestone to %9.0

  • Stan Hu mentioned in commit c21c98b8

    mentioned in commit c21c98b8

  • DJ Mountney added ~149423 label

    added ~149423 label

  • mentioned in issue #31059 (closed)

  • Picked into stable. Will be in 9.0.6.

  • Stan Hu mentioned in commit d02b0e3a

    mentioned in commit d02b0e3a

  • Please register or sign in to reply
    Loading