Mark comment as resolved can easliy be mistaken for rmark discussion as resolved
The tooltip for marking a comment as resolved is Mark as resolved
. There are no visual hints or explanation that it's possible to either resolve a comment or the entire discussion. With the Resolve discussion
button in the close vicinity, users might expect to resolve the discussion when clicking on Mark as resolved
.
MVC
Change tooltip text to Mark comment as resolved
Long term solution
With the additional discussion about the UI for applying suggestions https://gitlab.com/gitlab-org/gitlab-ce/issues/54405 and how to create a better code review experience https://gitlab.com/gitlab-org/gitlab-ce/issues/59582, it might be helpful to include the discussion about how to visualize resolving comments and discussion in the larger context. There is also another issue to discuss whether it would be helpful to resolve this functionality entirely https://gitlab.com/gitlab-org/gitlab-ce/issues/61870, which would solve the problem in this issue.