Skip to content

Resolve discussion when applying a suggested change

Problem to solve

It is now possible to suggest a change to a merge request from a comment https://gitlab.com/gitlab-org/gitlab-ce/issues/18008. If I propose a fix 99% of the time, if that change is applied, I am happy with the change and I will mark it resolved.

We should have great defaults, and automatically resolve the discussion when applying a suggestion, rather than asking the user to perform two action 99% of the time.

Further details

The original proposal was to include a checkbox (same as GitHub) because a single thread can often discuss multiple topics, but this has been resolved by allowing multiple discussions per line https://gitlab.com/gitlab-org/gitlab-ce/issues/32452

Suggesting a change Suggestion accepted, and discussion resolved
Screen_Shot_2019-04-08_at_11.06.55_AM Screen_Shot_2019-04-08_at_11.07.40_AM

Proposal

  • Giving the button a green outline
  • Tooltip with This also resolves the discussion on hover
  • Loading state while applying the suggestion
  • Adding bottom bar with feedback

Kapture_2019-05-04_at_6.36.14

Links / references

Edited by 🤖 GitLab Bot 🤖