Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab Community Edition
GitLab Community Edition
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 14,041
    • Issues 14,041
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 810
    • Merge Requests 810
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab Community EditionGitLab Community Edition
  • Issues
  • #53905

Closed
Open
Opened Oct 25, 2018 by Dimitrie Hoekstra@dimitrieh
  • Report abuse
  • New issue
Report abuse New issue

Prevent anyone from deleting protected environments

Problem to solve

Right now, you'll see the stop button if the user is allowed to stop the environment. With !22292 (merged) this will also be in the merge request widget for post-merge environments.

Being able to easily delete/stop a production environment is not something that should be encouraged. To do this with !22292 (merged) within the context of a feature branch is even worse.

The same protections should be applied via the UX as in the API for this to be considered coherent.

Further details

Proposal

Similar to protected branches, protected environments should prevent anyone from stoping/deleting them.

  • Maintainers by default have access, but the protected environment is also configurable to have a list of users who have access.
  • Only maintainers are allowed to create or designate (including removal of designation) protected environments
  • Only maintainers or those given access are allowed to run pipelines targeting the environment
  • Nobody is allowed to stop or delete the environment; protected status must be removed to allow this

image

What does success look like, and how can we measure that?

  • Protected environments are no longer easily stoppable/deletable.
  • The button for this will automatically be non accessible anymore in the merge request widget (taken !22292 (merged) is merged)

Links / references

!22292 (merged)

Edited Oct 29, 2018 by Jason Lenny

Related issues

Assignee
Assign to
Epic
12.0
Milestone
12.0
Assign milestone
Time tracking
None
Due date
No due date
13
Labels
Accepting merge requests Manage PM Ready Release UX backend devops:release direction environments feature frontend permissions release governance
Assign labels
  • View project labels
Reference: gitlab-org/gitlab-ce#53905