Set up support for tests of Git protocol 2

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22548 adds an e2e test of pushing over SSH using Git protocol 2.

It won't work unless the SUT supports Git protocol 2. It's supported on staging and there's an issue open to enable support on GitLab.com https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/5244

This issue tracks the tasks needed to:

• Add the tests:
  • SSH: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22548
  • HTTP: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22925
• Update gitlab-qa gitlab-qa!198 (merged)
  • Add documentation with instructions for enabling support when testing against GDK.
  • Add QA_CAN_TEST_GIT_PROTOCOL_V2 to list of supported env vars.
• Set QA_CAN_TEST_GIT_PROTOCOL_V2 to false in nightly pipelines: https://gitlab.com/gitlab-org/quality/nightly/merge_requests/9
• Set QA_CAN_TEST_GIT_PROTOCOL_V2 to false in package-and-qa pipelines: gitlab-qa!199 (merged)
• Allow support to be enabled in the omnibus images used for nightly and package-and-qa pipelines
  • Will be enabled in docker images in omnibus-gitlab#3836 (closed)
  • We may be able to do it sooner just for tests by modifying sshd_config using gitlab-qa

marked this issue as related to #51236 (moved)

changed the description

mentioned in issue #53345 (closed)

mentioned in merge request !22548 (merged)

changed the description

added [deprecated] Accepting merge requests label

changed the description

marked the checklist item Update gitlab-qa gitlab-qa!198 (merged) as completed

marked the checklist item Set QA_CAN_TEST_GIT_PROTOCOL_V2 to false in nightly pipelines: https://gitlab.com/gitlab-org/quality/nightly/merge_requests/9 as completed

marked the checklist item Set QA_CAN_TEST_GIT_PROTOCOL_V2 to false in package-and-qa pipelines: gitlab-qa!199 (merged) as completed

mentioned in merge request !22925 (merged)

changed the description

removed [deprecated] Accepting merge requests label

marked the checklist item HTTP: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22925 as completed

• Allow support to be enabled in the omnibus images used for nightly and package-and-qa pipelines

  • Will be enabled in docker images in omnibus-gitlab#3836 (closed)

  • We may be able to do it sooner just for tests by modifying sshd_config using gitlab-qa

@mlapierre I think omnibus-gitlab supports the v2 protocol since %11.6, see omnibus-gitlab!2864 (merged). :)

changed milestone to %11.8

changed milestone to %11.10

mentioned in issue #62132 (closed)

Milestone %11.10 has expired, this will be rescheduled to the next milestone in active development %12.0. If you think this is incorrect, please feel free to update the milestone to a more appropriate one.

We're also adding missed:11.10

changed milestone to %12.0

added missed:11.10 label

mentioned in issue #64290 (closed)

changed milestone to %12.3

added missed:12.0 label

This issue was mistakenly put to %12.3, but intended for %12.1, now we're using a one-off script to correct it. Sorry for the inconvenience.

changed milestone to %12.1

mentioned in issue #65094 (closed)

changed milestone to %12.2

added missed:12.1 label

mentioned in issue #66572 (closed)

mentioned in issue #66594 (closed)

mentioned in issue #66618 (closed)

changed milestone to %12.3

added missed:12.2 label

@at.ramya it looks like this is almost done? If not should we deprioritize this for the EE test gaps?

Thanks Mek! YEs, this cannot be addressed until Git V2 is enabled again.

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue