Skip to content
Snippets Groups Projects

Add QA_CAN_TEST_GIT_PROTOCOL_V2

Merged Mark Lapierre requested to merge ml-add-git-protocol-v2-env-var into master
All threads resolved!

Add QA_CAN_TEST_GIT_PROTOCOL_V2 so tests that require Git protocol v2 can be skipped in environments that don't support it.

Required so that the test added in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22548 can be skipped in nightly and package-and-qa pipelines until they can support Git protocol v2.

Edited by Mark Lapierre

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Lapierre added 1 commit

    added 1 commit

    • 2d10a7ba - Add QA_ENV_SUPPORTS_GIT_PROTOCOL_V2

    Compare with previous version

  • Mark Lapierre resolved all discussions

    resolved all discussions

  • Author Maintainer

    Thanks @godfat, I've made that change.

  • assigned to @godfat

  • Author Maintainer

    Just going to rename the variable as discussed here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22548#note_113501841

  • Mark Lapierre changed title from Add QA_ENV_SUPPORTS_GIT_PROTOCOL_V2 to Add QA_CAN_TEST_GIT_PROTOCOL_V2

    changed title from Add QA_ENV_SUPPORTS_GIT_PROTOCOL_V2 to Add QA_CAN_TEST_GIT_PROTOCOL_V2

  • Mark Lapierre changed the description

    changed the description

  • Mark Lapierre added 1 commit

    added 1 commit

    • 8873a509 - Add QA_CAN_TEST_GIT_PROTOCOL_V2

    Compare with previous version

  • Lin Jen-Shin approved this merge request

    approved this merge request

  • Author Maintainer

    @ddavison Could you please review and merge and release a new version?

  • assigned to @ddavison

  • Dan Davison
  • Dan Davison
  • one more discussion to resolve. everything LGTM!

  • Mark Lapierre added 1 commit

    added 1 commit

    • 43fd77d2 - Add QA_CAN_TEST_GIT_PROTOCOL_V2

    Compare with previous version

  • Author Maintainer

    Link added. Thanks @ddavison!

  • Mark Lapierre resolved all discussions

    resolved all discussions

  • Dan Davison approved this merge request

    approved this merge request

  • merged

  • Dan Davison mentioned in commit dd48e482

    mentioned in commit dd48e482

  • Dan Davison mentioned in merge request !200 (merged)

    mentioned in merge request !200 (merged)

  • Please register or sign in to reply
    Loading