Removing legacy RedCarpet rendering
Now that we've migrated from RedCarpet to CommonMark (in 11.4) for our Markdown processing for issues, merge requests, repository files, etc, we should look at removing all RedCarpet code - gem, legacy rendering support, etc.
Some things to think about / do:
-
what do we do about old issues/comments that are currently being rendered with redcarpet? Rewrite the data in a CommonMark compatible format (maybe using Pandoc)? Fine for us, but what about self-hosted?We won’t do anything for legacy data. See https://gitlab.com/gitlab-org/gitlab-ce/issues/51374#note_100662741 -
remove the
legacy_render
support -
keep the multiple markdown engine concept we're using (keep using
Banzai::Filter::MarkdownEngines::CommonMark
instead of moving code intoBanzai::Filter::MarkdownFilter
-
when? In a 11.x release, or wait until 12.0?
- Scheduled for 12.0.