Show a message when loading the issues / merge requests dashboard without filters
Design and requirements
- Copy:
Too many results
This would produce too many results for GitLab to handle. Please filter by any criteria to view the matching results.
-
Removed "Reset filters" in the filter bar.
-
Graphic:
issue-dashboard_results-without-filter
ingitlab-svgs
-
The
Issues
breadcrumb should link tohttps://gitlab.com/dashboard/issues?assignee_id=xxxx
. where the id is the one you get when you first arrive at the page from the top nav, i.e. it filters on yourself. -
The moment the user makes a filter change such that all the filter options are blank, you see the special graphic below.
The system doesn't bother sending any request to the backend. It just displays the graphic with the messaging.Per https://gitlab.com/gitlab-org/gitlab-ce/issues/43246#note_68183388, the system does make a BE request, but the expensive db call is avoided, so we still get the intended benefit of the issue. -
Applies to both issues dashboard page and merge request dashboard page, e.g.s:
-
Copy:
Please select at least one filter to see results
Discussion from before
The issues / MR dashboard view still times out sometimes: https://performance.gitlab.net/dashboard/db/rails-controllers?orgId=1&var-action=DashboardController%23issues
However, that always appears to be when there are no filters applied. (https://gitlab.com/gitlab-org/gitlab-ce/issues/37143 addressed the slow filters.)
I think we should:
- Show a message, and not return any results, if you have no filters.
- Remove the breadcrumb nav link to reset filters that you can see mentioned in https://gitlab.com/gitlab-org/gitlab-ce/issues/42995. Per https://gitlab.com/gitlab-org/gitlab-ce/issues/43246#note_61987315, the breadcrumb link should go to issues or MRs assigned to the current user.