Confidential issues page re-design
Resources
FE @selfup
Problems and discussion
- The design here (https://gitlab.com/gitlab-org/gitlab-ce/issues/33874#note_33276411) is pretty much what we have now. The new orange color proposed is definitely a welcome change to draw more attention.
- Linking to docs is great. But supposedly in the previous design, we followed the guidelines. Let's make sure we follow the guidelines, or change the guidelines, or make sure we understand why we are breaking the rules here. https://gitlab.com/gitlab-org/gitlab-ce/issues/29741#note_28772697.
- This design is good, because leaving a comment is definitely when you need to know about confidentiality. Your design leaves out the explicit statement in the current implementation regarding visibility. Not sure which is better. Feel free to give another design.
- The other info that might be helpful to indicate is that if you are cc-ing somebody without permissions, they will never get a notification, as mentioned here: https://gitlab.com/gitlab-org/gitlab-ce/issues/33840#note_32985691.
- I'm not sure if including both of these above points would be overkill. But these are problems to be solved, design-wise.
- We talked about how when you have scrolled away from the comment box, you do not know that you are looking at a confidential issue. I think this is a problem because when you are looking at the description for example, you should have confidence that you are looking at a confidential issue, and be re-assured. For example, you might be looking a sensitive customer information, and you want to have that assurance right away.
- The major complaints in https://gitlab.com/gitlab-org/gitlab-ce/issues/33840 is about intrusiveness of the banner design. I know intrusiveness and the point above are basically competing goals. I like how the banner would appear only when you scroll as a compromise. Or even the design here I think is good: https://gitlab.com/gitlab-org/gitlab-ce/issues/29741#note_26099441. I'm not sure which is the best. Please propose something. Or maybe you can propose a design that solves both problems (intrusiveness and lack of explicitness) at the same time.
- I would like to move the toggling of confidentiality away from the main description area of the issue. I'm suggesting the sidebar. The main reason for this goal is that the main area should be restricted for description (and title and template) only. Since we are moving away from web forms, I think the main area should be description and below that, the comment thread. Feel free to discuss if you disagree.
Design
- The icon in the header also has an orange background, so it looks more obvious. (Screen 01)
Screen 01 |
---|
Confidentiality in the sidebar
The issue is confidential:
- Message: Eye icon(orange) +
This issue is confidential
- Confirmation:
You are going to turn off the confidentiality. It means **everyone** will be able to see and leave comment on this issue.
The issue is not confidential:
- Message: Eye-slash icon +
None
- Confirmation:
You are going to turn on the confidentiality. It means that only team members with **at least Reporter** access are able to see and leave comment on this issue.
Interaction:
- Clicking
Edit
-->
- The confirmation section expands.
-
Edit
is changed to be aX
icon.
- Clicking
X
-->
- The confirmation section collapses.
- Clicking
Cancel
-->
- The confirmation section collapses.
01 - Issue is confidential | 02 - Confirmation | 03 - Issue is not confidential | 04 - Confirmation |
---|---|---|---|
Edited by Victor Wu