Skip to content

Decouple membership and notifications

Iteration 1 (8.7, done)

Currently if users a only part of a group they cannot specify different notification levels for individual projects. In Enterprises where LDAP group sync is used to manage membership this becomes a larger concern.

@dzaporozhets mentions that to accomplish this we need to decouple membership and notifications. How much time does this take? Can we schedule this for an upcoming release?

Required for https://gitlab.com/gitlab-org/gitlab-ce/issues/9013 and https://gitlab.com/gitlab-org/gitlab-ce/issues/12758

Iteration 2 (8.9)

See comments on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3421, and:

  • Done Create migration that remove duplicates in notification_settings table and create uniq index. add_index :notification_settings, [:user_id, :source_id, :source_type], uniq: true

  • In progress Move notification_level out of user and into NotificationSetting model with a nil source (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3421#note_4578089)

  • https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3421#note_4577930:

    Because we don't want not-changed-from-default NotificationSetting records laying around for every single user/project combination, I think we should have a method like user.notification_settings_for(project) that will lazily return either an existing NotificationSetting for this project, or a newly initialized one based on the group, or on the user's global level. The NotificationSetting will be made concrete (saved) only when the level changes from global.

    This abstraction should allow us to not bother about whether the notification settings exist in the DB at all, and do away with the find_or_initialize_by calls.

#Things to be done

  • Add notification level dropdown to Group page
  • Make proper API for notification settings
  • Use MemberCreateService instead of Member#after_create callback for creating notification settings (after #14709 (moved))
  • Check for possible UX improvements
  • Remove notification_level field from Member model in 9.0