Make emoji buttons aligned properly

Resources

FE @selfup

These emoji buttons are not vertically centered.

cc @timzallmann @tauriedavis @annabeldunstone @iamphill

added UI polish ~127616 labels

changed the description

added Deliverable label

changed milestone to %9.4

It seems that this has resolved itself in the 9.3 RCs.

Can anyone confirm? Looks aligned on .com

I think it is slightly off.

You can see here that the emoji extends above, which is causing it to not look vertically centered.

How big are emoji's normally? Shouldn't we just match the default to be the same height as all of our native emoji's?

Yeah, I would assume so. The only one that is different is the smiley because its an svg. But svg is correctly vertically aligned.

Ok I think I see what you are saying here. Thanks for clearing it up

mentioned in merge request !12686 (closed)

assigned to @selfup

So talked to @eric and it seems that GitHub has the same issues. On Windows this is their emoji:

On macOS:

And then on linux they are images instead of unicode so this might be an impossible task.

@annabeldunstone do you have any thoughts?

@selfup Because the glyph bounds are different across platforms and between emojis themselves, I think this might be a bit futile. We could tune one platform pretty well but it would look off in another. I am not aware of another product that has solved the alignment issue.

@MadLittleMods Just read your article in the blog, I'm kinda-sorta-indirectly helping with the alignment issue via Chromium - hope the situation improves as GL wasn't the only one facing this annoyance

Blog for reference: https://about.gitlab.com/blog/2018/05/30/journey-in-native-unicode-emoji/

@lorin Thanks for linking your Chromium issue! Emoji issues abound 🤯

I'm not sure what to do with that either. Stuff like this just seems to come with the territory of using system fonts/emojis.

What did we decide for this issue since it was a %9.4 Deliverable and that window has closed? @selfup

That is a good question! It seems that this would be a never ending battle.

On linux, emojis are not unicode they are images. Then on Windows certain versions have different types of unicode.

As @eric said, this would be bit futile to achieve.

@tauriedavis What are your thoughts?

tl;dr we would have to pick a certain OS for fine tuning, but that is not fair to our users

I don't think we should spend the effort it will take to fix each pixel alignment on each platform. The current alignment is not terribly noticeable and I think we've done a decent job given the limitations. Lets close for now.

closed

closed

mentioned in merge request !13881 (merged)

marked this issue as related to #29228 (closed)

marked this issue as related to #37147 (closed)