Make project and features visibility settings less confusing

Resources

FE @mikegreiling

The current view is really confusing and not UX friendly at all. Note this should also apply not only to changing settings, but also when creating a new project.

Original proposal

As a follow up to https://gitlab.com/gitlab-org/gitlab-ce/issues/24032, make it more streamlined:

• Use checkboxes to indicate enabled / disabled.
• Remove extra wording / explanations.
• Arrange features into their logical orderings.
• Re-name option choices to be more readable.
• Have better wording and descriptions of the settings and reference innersourcing for internal permission https://gitlab.com/gitlab-org/gitlab-ce/issues/33785

Proposal

• Use toggle to indicate enabled/disabled
• Arrange features into logical order
• Make project visibility visually distinct from features
• Move "Allow users to request access" to the top under project visibility and only show if public or internal
• Change placeholder text for disabled features to "Enable feature to choose access level"
• Keep green background that fades when changing project visibility
• Move access levels next to the feature toggle so you don't have to scan across the page to see the level related to each feature.
• Container registry and LFS is now placed under repository and always visible like the other features related to repository are.
• Update copy for private, internal, and public help text:

  • Private: The project is accessible only by members of the project. Access must be granted explicitly to each user.

  • Internal: The project can be accessed by any user who is logged in.

  • Public: The project can be accessed by anyone, regardless of authentication.

• Change Only team members to Only project members

Public	Private