Make it possible to use a presenter with serializer by default if it exists

Description

We now have serializers and presenters.

We use serializers to create payload we consume on the frontend (typically using Vue components). This means that serializers are meant to provide data for the frontend code, thus for the user interface as well.

Presenters are designed to create a object-oriented substitute of view helpers.

Those are related concepts.

Proposal

When someone wants to serialize a resource, instantiate a presenter for this resource automatically if it exists, and pass it to the serialization entities instead of passing a resource itself.

What do you think about it @rymai?

mentioned in issue #30896 (closed)

I agree, these concepts are related and that makes sense to pass a presenter to a serializer.

@grzesiek Btw, we need a app/serializers/README.md! :)

@rymai app/serializers/README.md is on my roadmap for %9.2 https://gitlab.com/gitlab-org/gitlab-ce/issues/26758

mentioned in merge request !10548 (merged)

@rymai It seems that this solution in a high demand recently. The more we move stuff to Vue, the more we use serializers and presenters, the more we need to make it easier to use presenters with serializers.

Example: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17814/diffs#note_68568032

I'm marking this as a technical debt.

added maintenancerefactor label

mentioned in merge request !17814 (merged)

mentioned in merge request !21391 (merged)

added [deprecated] Accepting merge requests label

removed [deprecated] Accepting merge requests label

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue

mentioned in merge request gitlab!148194 (merged)