Merge request comments disappear when changing commit
Summary
When commenting on a commit diff which is part of a merge request via the Commits tab, the comment disappears as soon as the commit is changed.
Steps to reproduce
- Open a merge request
- Go to commits tab
- Open a commit
- Add a comment on the diff
The comment appears on the merge request page, but it is not a discussion which can be resolved
- Change the commented commit by amending or interactive rebasing
- Force push the changed commit
The previously created comment disappears without any trace from the merge request page and the activity feed
The comment also disappears without any trace from the old commit diff which is still reachable through the GitLab UI
Expected behavior
Comments on commit diffs which are part of a merge request should be handled similar to a comment which is created via the changes tab in the merge request.
Actual behavior
The comment is not a resolvable discussion and - even worse - disappears without a trace when changing the corresponding commit this comment is attached to.
Affected Versions
GitLab CE 8.13.5