In most of the world outside of the USA, the first day of the week is Monday. The current datepicker always treats Sunday as the first day of the week. This can be confusing and should be considered as part of the internationalization project.
A user should be able to specify their preference for the first day of the week.
Proposal
Add a preference for users to nominate Start of the week with the options Sunday (default) or Monday
Links / references
Documentation blurb
Overview
What is it?
Why should someone use this feature?
What is the underlying (business) problem?
How do you use this feature?
Use cases
Who is this for? Provide one or more use cases.
Feature checklist
Make sure these are completed before closing the issue,
with a link to the relevant commit.
@ClemMakesApps@jschatz1 : A quick google shows that this is a common request for many apps. But this sounds like something that the system should enforce (along with the UI element), not the application logic itself. Do you agree? Is this what is normal for date-pickers? So your computer/browser should detect that you are from Europe, and pass that info to the date picker, and the date picker should display Monday first. Is that what should be done? Could that be built into https://github.com/dbushell/Pikaday/, which looks like where we are getting the date picker from.
It should be either system wide or event better user specific configuration with system wide default. The thing is, some browser do have implemented UI elements for input fields, but you are using custom library anyways, as its not everywhere supported.
Then again, I am using browser in English language because it feels more natural to me, having internet in English, then in a language that 2 million people speak and has very little support online, while locale settings are from my country and English locale is very confusing.
These kind of things confuse software auto-detect, so its better to have it set by user himself. Especially when we are talking about software development and project support tools.
Reading what @sonicelo https://gitlab.com/gitlab-org/gitlab-ce/issues/2105#note_38657130 says, to me this is indeed the case where the software should auto-detect where you are from, and give you the defaults (whether that is language and UI element conventions such as the datepicker). And then providing some level of customization (in addition) makes sense because modern day people definitely are very diverse and do not necessarily follow the conventions of their physical locale. For example, GitLab already allows language customization in some small degree.
I don't see this as being a high priority anytime soon. But I think it should be a ~Platform discussion where we have a clear strategy on what we allow to be customizable, if at all. @mydigitalself : I'll let you take it away here and you can bump it up if you think it's a priority.
Looking at the Pikaday docs, we can easily configure which day of the week we want to be the start of the week (on the picker). I think the question is more so, do we want to allow configuration and how would that look like
@ClemMakesApps@victorwu I think it would be better to let the user configure it's timezone instead of only the start of the week. This gives GitLab more possibilities.
@janten but based on the tz database time zone it should be possible to filter United States, Canada and Australia (and some other countries I think) which are using Sunday as the start of the week
We can't accurately detect where the user is from without a huge effort unless they set it themselves. This would be a pretty easy fix to make. We should schedule it @victorwu
@timzallmann any ideas for how we might catch this earlier in future? Perhaps we should just make this a backend feature since the frontend component is quite small?
Please, is there any progress on this feature? I can see it was previously assigned to the milestone %10.4 but I can understand that this hasn't been implemented yet. Am I right?
I fully support this feature request. As a European, it's quite confusing to have the date picker start on Sunday and end on Saturday. I would consider this quite a basic requirement.
@victorwu, @jramsay: Is there any update on this? It's still marked as Milestone 10.4, and according to his GitLab profile, "Mike Bartlett (@mydigitalself) left project GitLab.com / www-gitlab-com" 3 months ago.
We're still struggling to make time for this. I've been tracking it internally for planning purposes, but the ~Manage team has a lot on their plate. I've marked it %"Next 4-7 releases", since that's the likely timeline.
Like nearly all issues in GitLab, we're accepting merge requests for this one.
@jeremy_ I understand you or the Manage team have got a lot on their plate (don't we all... :-) ), but in a sense, this issue reflects how important non-US customers are to you as a company, and the result is, to be frank, quite disappointing. (even more so given this issue was opened more than 3 years ago).
Looks like @fabsrc is working on a Community contribution for this one, couldn't be happier to see progress on this much-requested addition from the community. Awesome contribution!