Skip to content

Remove danger-ruby-2.6.6 image in favor of danger

Takuya Noguchi requested to merge tnir-remove-danger-2.6.6 into master

What does this MR do and why?

Removes :danger-ruby-2.6.6 image in favor of :danger image since it is obsolete. Ruby 2.6 was EOL'd and Node.js 14 is getting EOL.

$ diff -u Dockerfile.danger{-ruby-2.6.6,}
--- Dockerfile.danger-ruby-2.6.6        2022-08-14 00:00:00.000000000 +0000
+++ Dockerfile.danger   2022-08-14 00:00:00.000000000 +0000
@@ -1,4 +1,4 @@
-FROM ruby:2.6.6-buster
+FROM ruby:2.7.5-buster
 MAINTAINER GitLab Quality Team
 
 # Danger manipulates git diff output. When a unicode char is present in the diff, it chokes with
@@ -6,7 +6,7 @@
 # eg. https://gitlab.com/gitlab-org/gitlab-foss/-/jobs/275286625
 ENV LC_ALL "C.UTF-8"
 
-ENV NODE_VERSION=14.17.2
+ENV NODE_VERSION=16.14.2
 ENV YARN_VERSION=1.22.17
 ENV GITLAB_GEM_VERSION=4.18.0
 ENV DANGER_GEM_VERSION=8.4.5

Also no one is using :danger-ruby-2.6.6 but :danger (Ruby 2.7 and Node.js 16.14-based):

Merge request reports