Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gitaly
gitaly
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 631
    • Issues 631
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 41
    • Merge Requests 41
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • gitalygitaly
  • Merge Requests
  • !987

Merged
Opened Nov 27, 2018 by Jacob Vosmaer@jacobvosmaer-gitlabOwner

Remove unused bridge_exceptions method

  • Overview 6
  • Commits 5
  • Pipelines 5
  • Changes 13

The bridge_exceptions method was part of a plan we didn't follow through on. The idea at the time was that we wanted to transparently re-raise gitaly-ruby exceptions in gitlab-ce. We never built the gitlab-ce part and we changed our approach to exceptions; we now use mostly use gRPC code FailedPrecondition if we want to signal an "expected exception".

This bridge_exceptions thing was just boilerplate that everybody keeps adding in new gitaly-ruby code.

Closes #608 (closed) #698 (closed)

Edited Nov 28, 2018 by Jacob Vosmaer
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: gitlab-org/gitaly!987
Source branch: remove-bridge-exceptions

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.