Skip to content

Only load Wiki formatted data upon request

Stan Hu requested to merge sh-lazy-load-wiki-pages into master

Previously the formatted data for each Wiki page requested would be generated unnecessarily. This would be expensive especially if the Wiki rendering required shelling out to another process, as reStructuredText files does. Now, we only load the formatted data and rely on the separate RPC to request the formatted data.

GitLab CE will automatically request formatted data if it is needed: https://gitlab.com/gitlab-org/gitlab-ce/blob/c2c9b3ddc71053cc9bc3754c8c6007ad8b6f653c/app/models/wiki_page.rb#L113-118

This is the ruby-prof output of the previous implementation for 15 reStructuredText files:

image

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/45860

Edited by GitLab Release Tools Bot

Merge request reports