Skip to content
Snippets Groups Projects

git: Add --skip git-rev-list in revisions.go

Merged Javiera Tapia requested to merge jtapiab/add-skip-pseudo-revision-list-commits into master

After Network/Graph view does not show tags which are... (gitlab!164081 - merged), some discrepancies were discovered between the FindAllCommitsRequest RPC and ListCommitsRequest RPC. The first one allows the field skip which, by definition, skip is the number of commits to skip before starting to show the commit output. This allows the Repository network graph to show commits centered by the commit SHA or refname.

To keep this behavior, we should include the --skip revision in internal/git/revision.go.

This MR adds --skip to the list of git-rev-list so it becomes possible to skip number commits before starting to show the commit output.

Related to #6368 (closed)

Edited by Javiera Tapia

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Javiera Tapia added 1 commit

    added 1 commit

    • a4604bf3 - Add --skip git-rev-list(1) in list_commits.go

    Compare with previous version

  • Javiera Tapia changed title from git: Allow --skip= pseudo revision in revisions.go to git: Add --skip git-rev-list in revisions.go

    changed title from git: Allow --skip= pseudo revision in revisions.go to git: Add --skip git-rev-list in revisions.go

  • Javiera Tapia changed the description

    changed the description

  • requested review from @justintobler

  • Justin Tobler approved this merge request

    approved this merge request

  • requested review from @samihiltunen

  • Javiera Tapia changed the description

    changed the description

  • Sami Hiltunen approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading