git: Add --skip git-rev-list in revisions.go
After Network/Graph view does not show tags which are... (gitlab!164081 - merged), some discrepancies were discovered between the FindAllCommitsRequest
RPC and ListCommitsRequest
RPC. The first one allows the field skip
which, by definition, skip is the number of commits to skip before starting to show the commit output.
This allows the Repository network graph to show commits centered by the commit SHA or refname.
To keep this behavior, we should include the --skip
revision in internal/git/revision.go
.
This MR adds --skip
to the list of git-rev-list so it becomes possible to skip number commits before starting to show the commit output.
Related to #6368 (closed)
Merge request reports
Activity
changed milestone to %17.5
added backend groupsource code typefeature workflowin review labels
assigned to @jtapiab
added devopscreate sectiondev labels
added Category:Source Code Management label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer None @justintobler
(UTC-5, 2 hours behind author)@toon
(UTC+2, 5 hours ahead of author)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger requested review from @justintobler
- Resolved by Javiera Tapia
@justintobler
Would you please take a look at this small MR? TIA
- Automatically resolved by Javiera Tapia
- Resolved by Javiera Tapia
added 1 commit
- a4604bf3 - Add --skip git-rev-list(1) in list_commits.go
requested review from @justintobler
requested review from @samihiltunen
mentioned in issue gitlab#496695 (closed)