Do not consider pool repos dangling on restore
%17.2 backport of !7146 (merged)
Pool repos are not explicitly backed up by gitlab-rails. So these repos would always be considered dangling. Removing existing pools will cause data-loss since they will already be storing objects from forks.
Changelog: fixed
Merge request reports
Activity
changed milestone to %17.2
added bugfunctional group::gitalygit labels
assigned to @proglottis
added typebug label
added Category:Gitaly devopssystems sectioncore platform labels
- A deleted user
added groupgitaly label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer None @justintobler
(UTC-5, 17 hours behind author)
@ahmadsherif
(UTC+2, 10 hours behind author)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded severity3 label
@justintobler mind taking a look at this backport too? I don't think I need a backport request for 1 release. I'm trying to figure out how we do this though
Thanks @proglottis! LGTM
For the backports I have done in the past, I've just merged the change into the corresponding stable release branch.
@justintobler @proglottis When is the v17.2 patch released?
When is the v17.2 patch released?
@jcaigitlab @mjwood Would you happen to know?
@dorrino - Do you happen to know when the v17.2 patch is released (and where we might be able to find a schedule)?
@mbursi do you know when the patch will go out?
I believe it will go out Wednesday though - https://handbook.gitlab.com/handbook/engineering/releases/#patch-release-cadence
@justintobler - looks like there is a documented release cadence!Thanks @dorrino!
@dorrino @mjwood - yes, we have Patch Releases on the Wednesday before and after the week of the Monthly release. In addition to that you can check the status of the next Releases (Monthly and Patch) in this dashboard (Login with Google): https://dashboards.gitlab.net/d/delivery-release_info/delivery3a-release-information?orgId=1
requested review from @justintobler
changed milestone to %17.3
added missed:17.2 label
mentioned in commit cbb0f5f6