Skip to content

WAL test permission fixes

James Fargher requested to merge wal_permission_fixes into master

More fixes for permission assertion failures between different development machines. Previously fixed in !6892 (merged) and !6966 (merged)

Ubuntu 23.10 sets umask to 0002 by default, this is different to the typical linux umask of 0022, and it meant that the testsuite was not passing as some file permission tests were not properly taking umask into account.

CI does not yet verify that we are umask agnostic, but it is simple enough to verify locally by setting umask before running the test suite.

E.g.

$ umask 000
$ make test-go
...
$ umask 002
$ make test-go
...
$ umask 022
$ make test-go
...

I've included the tar fix as suggested in but I cannot replicate this from my machine - !6966 (comment 1934465601)

Edited by James Fargher

Merge request reports