Skip to content

Fixed the unexpected issue of calibrating the limit to 0 in the AdaptiveCalculator

Qin ShiCheng requested to merge qeesung/gitaly:qsc/fixed_adaptive_setting_default_bound_value_zero into master

Use the New method to create an AdaptiveSetting object instead of directly creating it，If you directly create an AdaptiveSetting object, the fields Max, Min, and BackoffFactor will be initialized to 0, which unexpectedly results in the AdaptiveCalculator calibrate the new limit to 0

https://gitlab.com/gitlab-org/gitaly/-/blame/master/internal/limiter/adaptive_calculator.go#L256-258

https://gitlab.com/gitlab-org/gitaly/-/blame/master/internal/limiter/adaptive_calculator.go#L266-268

Merge request reports