Skip to content

Remove "error" key from backup create command output with level "warning"

Javiera Tapia requested to merge jtapiab-388521-change-error-by-warning-backup-skipped-repositories into master

What does this MR do and why?

The "Dumping repositories" phase of gitlab-backup can output "error" on warning which creates false positive alerts with log monitoring software.

This MR removes the error logrus field key.

Before

{"command":"create","error":"manager: repository not found: repository skipped","gl_project_path":"nosync-group.wiki","level":"warning","msg":"skipped create","pid":28035,"relative_path":"@groups/96/06/96061e92f58e4bdcdee73df36183fe3ac64747c81c26f6c83aada8d2aabb1864.wiki.git","storage_name":"default","time":"2023-09-20T05:23:08.142Z"}

After

{"command":"create","gl_project_path":"nosync-group.wiki","level":"warning","msg":"skipped create","pid":49268,"relative_path":"@groups/96/06/96061e92f58e4bdcdee73df36183fe3ac64747c81c26f6c83aada8d2aabb1864.wiki.git","storage_name":"default","time":"2023-09-20T05:10:17.563Z"}

How to validate this locally?

  • Use the bundle exec rake gitlab:backup:create rake task with a Gitlab instance with empty project wikis.
  • Check the output in the console

Related to gitlab#388521 (closed)

Edited by Javiera Tapia

Merge request reports