Skip to content

Draft: streamcache: Add support for symlinks

Arun requested to merge arkn98/gitaly:streamcache-symlink-support into master

Streamcache.filestore, currently, doesn't work when its directory is a symlink; the cleanup function ends up deleting it (see [1]). This commit fixes it by resolving the symlink to its absolute path during configuration.

The side-effects of this change are:

  • The log messages, label values, etc. will use the resolved path instead of the value set in pack_objects_cache.dir, if it was a symlink.
  • Since we lstat the path to check if it is a symlink, the errors that might happen during the cleanup (when cleanWalk() is run) can now happen during configuration.
  1. #4845

Fixes: #4845

Merge request reports