Skip to content

Add operation type annotations on RemoveAll

Sami Hiltunen requested to merge smh-remove-all-annotations into master

RemoveAll is missing operation type and scope annotations. These are needed to handle starting transactions for RPCs in a general manner. The RPC is missing the annotations as it is intercepted by Praefect and the annotations were previously only used by Praefect for deciding how to proxy the requests. As Gitaly will soon need the annotations itself, this commit adds the missing annotations.

TransactionService and PraefectInfoService service remain without annotations. These are only implemented by Praefect and thus Gitaly doesn't need annotations for them.

ServerService is also still left without annotations as there is no suitable scope for them anymore. Previously they were annotated with the now removed Server scope.

Merge request reports