Skip to content

Remove trace2 feature flags

Quang-Minh Nguyen requested to merge qmnguyen0711/remove-trace2-flags into master

This MR removes two feature flags:

  • gitaly_export_trace2_tracing. This flag allows Gitaly enables trace2 and export collected events as distributed tracing spans. After roll out that flag, everything was fine. GitLab.com didn't observe any performance impact. It's time to remove that flag. Even if it is removed, the exporter still enables trace2 only if the current code path has tracing enabled and sampled.
  • gitaly_export_trace2_pack_objects_metrics. This flag lets Gitaly start to capture metrics from git-pack-objects. Those metrics are exposed in two forms: log fields and Prometheus metrics.

Both flags were already enabled in production globally (#4997 (closed) and #4843 (closed)). It's time to remove them.

Merge request reports