temp_dir: Delete gitaly-0 runtime directory (!5217) · Merge requests · GitLab.org / gitaly · GitLab

Steve Xuereb requested to merge fix/cgroup-pid-0-deletion into master Dec 26, 2022

What

Delete gitaly-0 directory if it exists.

Why

In https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/16234#note_1082390476 we saw a directory inside of cgroups named gitaly-0 and Gitaly never cleaned it up because it goes under the assumption that it's a valid pid, which 0 isn't.

Reference: https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/16271 Signed-off-by: Steve Azzopardi sazzopardi@gitlab.com