Skip to content

Remove Wiki* in ruby sidecar - Part 2

Quang-Minh Nguyen requested to merge qmnguyen0711/4513-clean-up-gitaly-wiki-grpcs-in-gitaly-2 into master

A follow-up of !4955 (merged)

Wiki feature group is a well-known feature of GitLab. Underlying, all Wiki data are organized as Git repository. In prior versions, we created dedicated RPCs to handle Wiki-related requests. Those RPCs are then handled by Gitaly Ruby sidecar (powered by Gollum and Rugged gem).

In an attempt to remove the ruby sidecar completely, we migrated clients to use normal repository to handle Wiki-specific logic. This migration finished in %15.5. It's time to wipe corresponding handlers in Gitaly. In details:

  • Remove Wiki.proto protobuf definitions
  • Remove Wiki code paths in Ruby
  • Remove orphan utility methods
  • Remove some leftovers in Gitaly and Praefect

This MR doesn't remove rugged gem intentionally because rugged gem is referenced somewhere else, even in Gitaly and Praefect. So, I'll remove it in the next MR (part 3).

Edited by Quang-Minh Nguyen

Merge request reports