Skip to content

Revert "Merge branch 'qmnguyen0711/add-limit-offset-to-search-files-by-names' into 'master'"

James Fargher requested to merge revert-f8c627ee into master

This reverts merge request !4911 (merged)

This change is causing test failures in gitlab-rails:

Projects::BlobController (JavaScript fixtures)
  blob/show_readme.html (FAILED - 1)

Failures:

  1) Projects::BlobController (JavaScript fixtures) blob/show_readme.html
     Failure/Error: value = recording_request { response.next }
     
     ActionView::Template::Error:
       13:SearchFilesByName: cmd failed: exit status 128. debug_error_string:{"created":"@1665521272.990954128","description":"Error received from peer unix:tmp/tests/gitaly/gitaly.socket","file":"src/core/lib/surface/call.cc","file_line":1063,"grpc_message":"SearchFilesByName: cmd failed: exit status 128","grpc_status":13}
     # ./config/initializers/enumerator_next_patch.rb:9:in `block (2 levels) in <module:EnumeratorNextPatch>'
     # ./lib/gitlab/gitaly_client/call.rb:43:in `block (3 levels) in instrument_stream'
     # ./lib/gitlab/gitaly_client/call.rb:55:in `recording_request'
     # ./lib/gitlab/gitaly_client/call.rb:43:in `block (2 levels) in instrument_stream'
     # ./lib/gitlab/gitaly_client/call.rb:42:in `loop'
     # ./lib/gitlab/gitaly_client/call.rb:42:in `block in instrument_stream'
     # ./lib/gitlab/gitaly_client/repository_service.rb:319:in `each'
     # ./lib/gitlab/gitaly_client/repository_service.rb:319:in `each'
     # ./lib/gitlab/gitaly_client/repository_service.rb:319:in `flat_map'
     # ./lib/gitlab/gitaly_client/repository_service.rb:319:in `search_files_by_regexp'
     # ./lib/gitlab/git/repository.rb:1067:in `search_files_by_regexp'
     # ./app/models/wiki.rb:459:in `find_matched_file'
     # ./app/models/wiki.rb:476:in `find_page_with_repository_rpcs'
     # ./app/models/wiki.rb:220:in `find_page'
     # ./app/models/wiki.rb:172:in `has_home_page?'
     # ./app/models/blob_viewer/readme.rb:17:in `render_error'
     # ./app/views/projects/blob/_auxiliary_viewer.html.haml:3:in `_app_views_projects_blob__auxiliary_viewer_html_haml___1895096618711939551_643320'
     # ./app/views/projects/blob/_blob.html.haml:14:in `_app_views_projects_blob__blob_html_haml___1224183200745710769_642040'
     # ./app/views/projects/blob/show.html.haml:14:in `_app_views_projects_blob_show_html_haml__1695613753281694808_641980'
     # ./app/controllers/application_controller.rb:142:in `render'
     # ./app/controllers/projects/blob_controller.rb:241:in `show_html'
     # ./app/controllers/projects/blob_controller.rb:66:in `block (2 levels) in show'
     # ./app/controllers/projects/blob_controller.rb:64:in `show'
     # ./app/controllers/application_controller.rb:582:in `block in allow_gitaly_ref_name_caching'
     # ./lib/gitlab/gitaly_client.rb:318:in `allow_ref_name_caching'
     # ./app/controllers/application_controller.rb:581:in `allow_gitaly_ref_name_caching'
     # ./ee/lib/gitlab/ip_address_state.rb:10:in `with'
     # ./ee/app/controllers/ee/application_controller.rb:45:in `set_current_ip_address'
     # ./lib/gitlab/auth/current_user_mode.rb:72:in `with_current_admin'
     # ./app/controllers/application_controller.rb:534:in `set_current_admin'
     # ./lib/gitlab/session.rb:11:in `with_session'
     # ./app/controllers/application_controller.rb:522:in `set_session_storage'
     # ./lib/gitlab/i18n.rb:107:in `with_locale'
     # ./lib/gitlab/i18n.rb:113:in `with_user_locale'
     # ./app/controllers/application_controller.rb:516:in `set_locale'
     # ./app/controllers/application_controller.rb:510:in `set_current_context'
     # ./spec/frontend/fixtures/blob.rb:34:in `block (2 levels) in <top (required)>'
     # ./spec/support/helpers/javascript_fixtures_helpers.rb:25:in `block (3 levels) in <module:JavaScriptFixturesHelpers>'
     # ./spec/support/helpers/javascript_fixtures_helpers.rb:25:in `block (2 levels) in <module:JavaScriptFixturesHelpers>'
     # ./spec/spec_helper.rb:417:in `block (3 levels) in <top (required)>'
     # ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
     # ./spec/spec_helper.rb:409:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:405:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/application_context.rb:58:in `with_raw_context'
     # ./spec/spec_helper.rb:405:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:242:in `block (2 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'
     # ------------------
     # --- Caused by: ---
     # GRPC::Internal:
     #   13:SearchFilesByName: cmd failed: exit status 128. debug_error_string:{"created":"@1665521272.990954128","description":"Error received from peer unix:tmp/tests/gitaly/gitaly.socket","file":"src/core/lib/surface/call.cc","file_line":1063,"grpc_message":"SearchFilesByName: cmd failed: exit status 128","grpc_status":13}
     #   ./config/initializers/enumerator_next_patch.rb:9:in `block (2 levels) in <module:EnumeratorNextPatch>'

Finished in 49.64 seconds (files took 8.85 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/frontend/fixtures/blob.rb:33 # Projects::BlobController (JavaScript fixtures) blob/show_readme.html

/cc @qmnguyen0711

Merge request reports