Skip to content

fix(git2go): move integration tests from gitaly-git2go entirely to git2go

Savely Krasovsky requested to merge L11R/gitaly:move-integration-tests-2 into master

For some unknown reason integration tests of gitaly-git2go was divided between two packages: git2go and gitaly-git2go. In my opinion gitaly-git2go should contain only unit tests (but it currently does not have them) and git2go should contain all integration tests for gitaly-git2go.

For now gitaly-git2go contains most of the tests and git2go only commit_test.go and apply_test.go. Why?

!4802 (merged) needs tests, but current situation arises some problems like:

  1. Cannot use shared functions for tests like getCommit from commit_test.go.
  2. Has to create two testdata dirs with GPG keys.
Edited by Savely Krasovsky

Merge request reports