config: Don't treat EPERM as error when signalling (!4716) · Merge requests · GitLab.org / gitaly

Will Chandler requested to merge wc-prune-reused-pid into master Jul 15, 2022

When pruning Gitaly's runtime directory we send the equivalent of kill -0 <PID> to validate the process has ended. However, if the pid has been reused by the kernel for a process owned by another user we will receive EPERM, causing Gitaly to exit with an error.

On systems where dozens or hundreds of old runtime directories have accumulated over months, the odds of our hitting a reused pid are quite high.

Let's treat EPERM as acceptable in this scenario, as we know that the process we tried to signal can't be Gitaly if it's owned by another user.

Edited Jul 15, 2022 by Will Chandler

config: Don't treat EPERM as error when signalling