Skip to content

operations: Always use structured errors for UserSquash

Patrick Steinhardt requested to merge pks-user-squash-always-use-structured-errors into master

With d88d2918 (operations: Return error from UserSquash when resolving revisions fails, 2022-03-01), we have converted UserSquash to return structured errors in some cases where it previously returned no errors at all. Instead, the RPC used to embed the error in the response struct via the GitError field. This has made us blind for actual issues which happen in production, and furthermore it trips Praefect's logic which decides whether we need to create repliction jobs or not.

Rails has been adapted already in c7bcaadf193 (gitaly_client: Handle detailed errors for UserSquash, 2022-03-02), and the changes have been rolled out to production. While we required one follow-up fix to the new error codes we returned in 6c63998a (operations: Fix wrong error code when UserSquash conflicts, 2022-03-11), the rollout has otherwise been successful.

Remove the feature flag altogether and deprecated the GitError field, which isn't used anymore.

Changelog: changed

Closes #4099 (closed)

Merge request reports