Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gitaly gitaly
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 557
    • Issues 557
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 53
    • Merge requests 53
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • gitalygitaly
  • Merge requests
  • !4113

sql-migrate: Update storage_repositories table

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Pavlo Strokov requested to merge ps-fix-link-repo-14-4 into 14-4-stable Nov 20, 2021
  • Overview 3
  • Commits 1
  • Pipelines 4
  • Changes 1

The batch update query introduced to mitigate limitation of the PostgreSQL on amount of payload size that can be send by the NOTIFY function was missing a condition in the update statements. Because of that the payload contained changes not for the N storage-repository entries, but for (N * num_of_storages) storage-repository entries. So initial size of 150 becomes 450 if 3 storages used.

The change also includes significantly reduced batch size. The calculation was done on the test data similar to the production used data. The approximate payload size for single row is about 470 bytes. As max payload size is 8k bytes we are allowed to use no more than 16~17 entries. To be more realistic we reduce it to 14.

Part of: #3806 (closed)

Changelog: fixed

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ps-fix-link-repo-14-4