praefect: Backport separate endpoint for datastore collector (v14.2)
This MR backports !4085 (merged) and !4092 (merged) to v14.2.
Part of #3920 (closed), #3286 (closed)
Merge request reports
Activity
changed milestone to %14.2
assigned to @pks-t
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer ~ Ævar Arnfjörð Bjarmason ( @avar
) (UTC+1, same timezone as@pks-t
)John Cai ( @jcaigitlab
) (UTC-5, 6 hours behind@pks-t
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by GitalyBotrequested review from @8bitlife and @samihiltunen
removed review request for @8bitlife
@pks-t looks like it has conflicts.
Edited by Pavlo Strokov@8bitlife Fixed now. The backport in !4072 (merged) was already on that branch, and I've based my changes on top of the current tag instead of on the stable branch. And !4072 (merged) already contained most of the first two commits I cherry-picked, even though the backport had a (small) bug.
added 8 commits
-
8930d4d3...36bb64f6 - 5 commits from branch
14-2-stable
- 35844da3 - prometheus: Avoid duplicated metrics registration
- e53840b2 - praefect: Add ability to have separate database metrics endpoint
- 32526b78 - praefect: Do not collect repository store metrics on startup
Toggle commit list-
8930d4d3...36bb64f6 - 5 commits from branch
requested review from @8bitlife
mentioned in commit 313d9f85