Revert catfile cache refactor

This reverts !3853 (merged) since we believe it's leading to a Goroutine leak in gitlab-com/gl-infra/production#5566 (closed).

I was able to reproduce the leak with version:

Gitaly, version 14.3.0-rc2-45-ge6374eaf6

With this revert, the leak was not there.

assigned to @stanhu

added devopscreate label

	3 Warnings
	This merge request is quite big (1700 lines changed), please consider splitting it into multiple merge requests.
	CHANGELOG missing. To ceate a changelog, annotate one or more commits with the Changelog Git trailer. If you want to annotate the latest commit, you can do so using git commit --amend. If you want to annotate older or multiple commits, you need to do so using git rebase -i. When adding the trailer, you can use the following values: added fixed changed deprecated removed security performance other For example: This is the subject of your commit. This would be the body of your commit containing some extra details. Changelog: added If your merge request doesn't warrant a CHANGELOG entry, consider adding any of the documentation, ~"tooling", ~"tooling::pipelines", ~"tooling::workflow", ci-build, meta labels. See the documentation.
	No milestone was set, nor could it be detected from the issues this merge request closes.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
~	Christian Couder (@chriscool) (UTC+2, 9 hours ahead of @stanhu)	Toon Claes (@toon) (UTC+2, 9 hours ahead of @stanhu)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Carrying over some context from the associated incident: gitlab-com/gl-infra/production#5566 (comment 683373705)

added 1 commit

• 5d47b529 - Use io.CopyN instead of ioutil.CopyN

Compare with previous version

requested review from @toon, @samihiltunen, and @pks-t

changed milestone to %14.4

changed the description

added sectiondev label

approved this merge request

merged

mentioned in commit f99dae3b

mentioned in merge request !3905 (merged)

added workflowstaging-canary label

added workflowstaging label and removed workflowstaging-canary label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

mentioned in merge request !3886 (merged)

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

added workflowstaging-ref label and removed workflowproduction label

Due to an issue the workflowstaging-ref label was incorrectly applied to this merge request. Re-setting back to workflowproduction using https://gitlab.com/gitlab-org/release-tools/-/merge_requests/1620

added workflowproduction label and removed workflowstaging-ref label