Skip to content

Accept array of patterns in CreateBundleFromRefList

James Fargher requested to merge fix_patterns_create_bundle_from_ref_list into master

gitlab#35862 (closed)

I realised while completing !3731 (merged) that I had made some mistakes while specifying the RPC for CreateBundleFromRefList. So this MR is intended to fix those:

  • GRPC strings are expected to be well formed UTF-8, but ref names aren't. So to be able to specify all refs we need to use byte arrays.
  • We should be packing frames as much as possible for efficiency. So accept an array of patterns per frame.

This RPC was introduced in %14.2 !3594 (merged) and has no callees. So although this is a breaking change, it wont affect anything.

Edited by James Fargher

Merge request reports