Skip to content

Bump Shell dep to break the dependency on the old Gitaly package

Mikhail Mazurskiy requested to merge ash2k/bump-shell into master

Hey, I’m trying to update the agent to use Gitaly v14 package and it’s all good, all works fine but I’ve noticed that there is still a dependency on the unversioned package.

# in Agent repo
go mod graph | grep gitlab.com/gitlab-org/gitaly@
gitlab.com/gitlab-org/gitlab-shell@v1.9.8-0.20201117050822-3f9890ef73dc gitlab.com/gitlab-org/gitaly@v1.68.0
....

So it’s because Gitaly v14 brings in shell and it depends on the old package. I found your MR gitlab-shell!481 (merged) and that’s great. I tried updating the gitaly -> shell dependency to bring in the update, but even after it's done, the dependency on the old package is still there.

# in Gitaly repo after update to latest Shell commit
go mod graph | grep gitlab.com/gitlab-org/gitaly@
...
gitlab.com/gitlab-org/gitlab-shell@v1.9.8-0.20200506213341-716e30c55e89 gitlab.com/gitlab-org/gitaly@v1.68.0

I think the way forward is to bump Shell in Gitaly and then bump Gitaly dep in Shell to break the cycle 🤕

Relates to #3177 (closed).

Edited by Mikhail Mazurskiy

Merge request reports