Skip to content

Do not initialize NodeManager with repository specific primaries

Sami Hiltunen requested to merge smh-dont-init-node-manager into master

  • Praefect's Server service is no longer using NodeManager but it's still injected there as a dependency. This commit removes the unused field.

  • Repository specific primaries were implemented with multiple components that independently perform the functionalities previously grouped in NodeManager. NodeManager's interfaces were not flexible enough for properly testing repository specific primaraies and to subsitute parts of it. Now that the all the uses have been modified to take repository specific primaries into account, we don't have to initialize NodeManager anymore when the elector is enabled.

The only location where NodeManager must still be plugged into is Praefect's ConsistencyCheck which is used by the reconcile sub-command. As the reconcile sub-command does not work with repository specific primaries, injecting a nil NodeManager there is fine until we manage to remove the virtual storage scoped primary related code hopefully after 14.0.

Related to #3492 (closed)

Merge request reports