Skip to content

Fix flaky test TestDial_Tracing/stream

Sami Hiltunen requested to merge smh-fix-dial-test into master

This commit fixes TestDial_Tracing/stream which is flaking and failing the pipeline every now and then.

The ordering of the items is indeterministic due to a race in finishing two spans. The main test goroutine does not wait for the stream to close but only receives a single message. Once that message is received, both the main test goroutine and the stream handler race to finish their spans. This commit fixes the situation by making the main test goroutine wait for the stream to close and only then finishing its span.

Closes #3402 (closed)

Edited by Sami Hiltunen

Merge request reports

Loading