Remove Ruby code for 100% on user_delete_{branch,tag} in Go feature
A follow-up to a96949ae (Enable feature flag
go_user_delete_{branch,tag} by default, 2021-01-12). A relevant
message I posted in Slack[1] about it in #g_create_gitaly:
For removing the Ruby side of a full-on Ruby->Go feature, I've got some questions about how/what to remove:
-
This is user_delete_{tag,branch}, removing the code in ruby/lib/gitaly_server/operations_service.rb is obvious.
-
But that code calls rm_{tag,branch} in ruby/lib/gitlab/git/operation_service.rb, that seems (but not sure) to be the library gitlab.git will use to call us, but is that also legacy code at this point? Can't find where it's still used.
-
There's also e.g. the UserDeleteTagResponse left, which is the proto response. Is there something to configure to make the Ruby code in ruby/proto/gitaly/operations_pb.rb not be generated on make proto? Or is that imported into gitlab.git ...
-
Anything else? I just know about the caveat of removing this in 2x releases, but the change to make it on by default just went out, so OK to remove the Ruby code after that AFAIK.
So perhaps we need to remove more things here, but this is plenty for now.