Skip to content

danger: Remove ZJ from suggested reviewers

Zeger-Jan van de Weg requested to merge zj-no-reviewer into master

With this change there's a difference between reviewers and maintainers. Reviewers imply that if a Which only recommends who gets suggested as reviewer, and this excludes me, zj-gitlab, from being suggested. For the next few weeks and months I'm going to limit reviews this way to leave more time to build the Gitaly team.

Since a few weeks I've had some training from outside of GitLab through Plato, as well as continuous calls with other EMs within GitLab. Feedback I get, is that I'm very involved technically. I personally feel like that's the biggest leverage I can provide to the team and this should be considered a feature, not a bug. The counter to that is that I don't developer and use the other skills for the team either.

While this change in terms of lines changed is small, it signifies another iteration of becoming more of an engineering manager over and engineering manager. After an undetermined amount of time I might roll this back, this will be done based on the teams feedback, as well as my manager, and what GitLab chooses to value in engineering managers.

This change doesn't mean I won't review code anymore, just much less.

Edited by Zeger-Jan van de Weg

Merge request reports