Skip to content

Include grpc_service in gitaly_service_client_requests_total metric

Andrew Newdigate requested to merge include-service-in-request-counters into master

In gitlab-com/runbooks!2744 (merged), apdex scores were divided according to the grpc_service label.

This is because OperationService is usually quite slow compared to other services and can have upstream dependencies.

Unfortunately gitlab-com/runbooks!2744 (merged) is broken since gitaly_service_client_requests_total does not include the grpc_service label.

This MR adds that label, without the extra cardinality of also adding grpc_method.

cc @zj-gitlab

Edited by Andrew Newdigate

Merge request reports