Skip to content

Make --literal-pathspecs optional for LastCommitForPath

Stan Hu requested to merge sh-add-last-commit-for-path-literal-option into master

By default, we assume the pathspec is a glob spec, but there is now a boolean field in the protobuf to add the --literal-pathspecs argument. Changes to GitLab Rails will be needed to use this field to fix #2857 (closed).

This restores the changes in !2271 (merged) that were reverted in !2282 (merged), but now the boolean flag allows the caller decide which mode to use. Apparently GitLab was using the ListCommitForPath parameter as a glob spec when computing a hash of a pipeline cache key (gitlab#222356 (closed)).

Edited by GitLab Release Tools Bot

Merge request reports