Skip to content

Remove usage of gitlab shell yml

John Cai requested to merge jc-deprecate-gitlab-shell-yml into master

Since we are now passing values from gitaly's config.toml to gitlab shell hooks through an environment variable, we can deprecate usage of the legacy yml file.

This MR also updates the services/operations tests. One detail of the operations tests is that it requires a rubyserver which is quite expensive to start. For this reason, it's preferable to only spin up 1 ruby server for the package. Since the gitlab shell values like the gitlab_url is passed through to the ruby code when the rubyserver's .Start method gets called, we need to use just one test gitlab server for all the tests and that means we can only use one set of glID, glRepository for all the tests because those values are passed into the test gitlab server as options that get asserted against.

To accomplish this, a package level GlID value has been added that all the tests refer to. This is not ideal, because new tests will need to use this value otherwise the tests will fail when going through the package level gitlab test server.

However, this is also temporary as we plan to get rid of gitlab shell ruby hooks as we port them over to go.

fixes: #2182 (closed)

omnibus, CNG/Charts have all been updated to write configs to gitaly.toml:

Edited by GitLab Release Tools Bot

Merge request reports