Skip to content

Restore ee267, improve test coverage

John Cai requested to merge jc-revert-revert-ee267 into master

this MR reverts the revert of ee267, and adds test coverage so that both code paths get exercised:

  1. when gitaly does not pass gitlab shell config to gitlab shell as an env var
  2. when gitaly does pass gitlab shell config to gitlab shell as an env var

now that !2104 (merged) is merged, we are guarded against using empty values when gitaly passes a non-empty json object as http settings eg;

{"http_settings":{"user":"", "password":""}}
Edited by John Cai

Merge request reports