Skip to content

WIP: Add gitlabshell config values to gitaly toml

John Cai requested to merge jc-add-gitlabshell-config-to-gitaly-config into master

Currently, the hooks part of gitlab shell functionality is part of gitaly under ruby/gitlab-shell. For historical reasons, this code uses configs that live under ruby/gitlab-shell/config.yml. This means gitaly configs live across two separate files, which is not ideal. Additionally, we are moving towards migrating the hooks into gitaly and eventually porting everything to Go.

In order to prepare for this transition, the first step is to move the relevant configs from ruby/gitlab-shell/config.yml into gitaly's config.toml.

To safely deprecate ruby/gitlab-shell/config.yml, we will pass in the gitlab shell config values through an environment variable which is a json-encoded string of all the gitlab shell config values. But in order to keep this MR relatively small, those changes will be included in a separate MR.

This MR will only include the ruby changes.

Edited by John Cai

Merge request reports